[tmva][sofie] Improvements to SOFIE Keras parser on the Python side#22381
Merged
Conversation
guitargeek
force-pushed
the
tmva-sofie-pyz
branch
2 times, most recently
from
e342e8a to
77629bd
Compare
Re-implement the binary operator creation in the Keras parser code path in C++, so the Python side Keras parser implementation doesn't have to deal with SOFIE implementation details like the `EBasicBinaryOperator` or which binary operator types are supported. This also fixes a logic error where a binary operator with any name was falling back to multiplication.
guitargeek
force-pushed
the
tmva-sofie-pyz
branch
from
77629bd to
1f0aeda
Compare
This makes the overload that takes memory by raw pointer more consistent with the other overload that takes a `std::shared_ptr<void>`. This avoids also the need for some template instantiations on the SOFIE Pythonizations side, saving some memory cost.
guitargeek
force-pushed
the
tmva-sofie-pyz
branch
from
1f0aeda to
0685a1f
Compare
Test Results 22 files 22 suites 3d 14h 32m 38s ⏱️ For more details on these failures, see this check. Results for commit 0685a1f. ♻️ This comment has been updated with latest results. |
aaronj0
approved these changes
May 24, 2026
Contributor
aaronj0
left a comment
aaronj0
left a comment
There was a problem hiding this comment.
I am not familiar with SOFIE, but these look like good improvements to me from a pythonization standpoint. This makes the usage of cppyy more sane, by no longer relying on wrapper generation for template types that can resolve to ndarray.
For MakeKerasBinary, it is also good that we moved the logic to C++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements to the SOFIE Keras parser on the Python side, inspired by the cppyy upgrade work.
This also fixes a logic error where a binary operator with any name was falling back to multiplication.